Remove generated examples, its unclear what it means. #3354
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
Friendly ping on this :) I realize that most people don't have a strong opinion, but it would be good to get this merged or commented :) |
|
AFAIK we never completely finished off generating good examples. I'm fine removing this for now since that's more accurate, with the understanding that if @pwittrock (or someone else) makes that work & easy, we will put it back. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lavalamp thanks, definitely fine with the idea, just that it is more or less impossible to achieve in the current form. Happy to add it back in when the tools are better. |
As far as I can tell this qualification is poorly understood, and actually not a great goal anyway, since the generated examples (e.g. https://github.com/kubernetes-client/java/blob/master/kubernetes/docs/AppsV1Api.md#deleteCollectionNamespacedDaemonSet) aren't really that useful anyway.
There's separate requirements about docs for the
stablestatus below, and this is confusing various people(e.g. kubernetes-client/javascript#182)
Thus, I think it makes sense to delete this requirement.
cc @lavalamp @mbohlool